fix: 🐛 forceScroll error #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
我可能还需要更新一下测试用例，稍等。 |
berber1016
force-pushed
the
fix-change-ref-forceScroll-error
branch
from
839b483
to
756e1d4
Compare
berber1016
force-pushed
the
fix-change-ref-forceScroll-error
branch
from
756e1d4
to
1ca519f
Compare
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 99.39% 99.40%
=======================================
Files 36 36
Lines 999 1004 +5
Branches 301 304 +3
=======================================
+ Hits 993 998 +5
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@afc163 Excuse me, who can take care of this PR |
|
这样延迟过于明显了： Kapture.2022-09-05.at.14.43.10.mp4 |
iShot_2022-09-05_19.15.12.mp4这是原有效果，我理解始终是有延迟问题，想解决这个问题本质上需要重新设计滚动😄 |
|
@zombieJ @berber1016 比较好奇为啥我设置了 sticky 后延迟的问题会很明显，没设置之前几乎感觉不到。这里面是有逻辑差异吗 |
能提供一个复现案例吗，听上去不太像我这个mr引入的问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#37179
当动态新增
columns时，调用forceScroll方法，设置scrollLeft，并不起作用，发现此时的scrollLeft为 0，MDN文档
此时我打印了
scrollWidth，发现scrollWidth与预期不同，正常scrollWidth应该为 1800(此值为上方bug链接中的案例)， 此时为 358， 与offsetWidth，猜测符合MDN中说的第一条规则，如果元素不能滚动（比如：元素没有溢出），那么scrollLeft 的值是 0。解决办法：
我能想到的就是将
scrollLeft设置推迟到 dom 更新后执行，不知道有没有更好的办法😮💨